use zap for logging http requests as well
2 files changed, 9 insertions(+), 21 deletions(-)
M internal/server/logging.go → internal/server/logging.go
@@ -1,9 +1,8 @@ package server import ( - "fmt" - "io" "net/http" + "website/internal/log" ) type loggingResponseWriter struct {@@ -25,7 +24,6 @@ } type wrappedHandlerOptions struct { defaultHostname string - logger io.Writer } func wrapHandlerWithLogging(wrappedHandler http.Handler, opts wrappedHandlerOptions) http.Handler {@@ -41,15 +39,14 @@ } lw := NewLoggingResponseWriter(w) wrappedHandler.ServeHTTP(lw, r) statusCode := lw.statusCode - fmt.Fprintf( - opts.logger, - "%s %s %d %s %s %s\n", - scheme, - r.Method, - statusCode, - host, - r.URL.Path, - lw.Header().Get("Location"), + log.Info( + "http request", + "scheme", scheme, + "method", r.Method, + "status", statusCode, + "host", host, + "path", r.URL.Path, + "location", lw.Header().Get("Location"), ) }) }
M internal/server/server.go → internal/server/server.go
@@ -3,7 +3,6 @@ import ( "context" "fmt" - "io" "mime" "net" "net/http"@@ -19,7 +18,6 @@ "github.com/getsentry/sentry-go" sentryhttp "github.com/getsentry/sentry-go/http" "github.com/pkg/errors" - "github.com/shengyanli1982/law" ) var config *cfg.Config@@ -168,17 +166,10 @@ newURL := runtimeConfig.BaseURL.String() + r.URL.String() http.Redirect(w, r, newURL, 301) }) - var logWriter io.Writer - if runtimeConfig.Production { - logWriter = law.NewWriteAsyncer(os.Stdout, nil) - } else { - logWriter = os.Stdout - } top.Handle("/", sentryHandler.Handle( wrapHandlerWithLogging(mux, wrappedHandlerOptions{ defaultHostname: runtimeConfig.BaseURL.Hostname(), - logger: logWriter, }), ), )