Add LabelEl (#180) For consistency with the other name clashes. Also, adjust the readme. I know it's a bit weird to add a pre-deprecated function, but know it's the same as the other functions.
Markus Wüstenberg markus@maragu.dk
Tue, 25 Jun 2024 14:47:01 +0200
3 files changed, 8 insertions(+), 1 deletions(-)
M README.md → README.md
@@ -145,11 +145,12 @@ For more complete examples, see [the examples directory](examples/). ### What's up with the specially named elements and attributes? -Unfortunately, there are four main name clashes in HTML elements and attributes, so they need an `El` or `Attr` suffix, +Unfortunately, there are five main name clashes in HTML elements and attributes, so they need an `El` or `Attr` suffix, to be able to co-exist in the same package in Go. I've chosen one or the other based on what I think is the common usage. In either case, the less-used variant also exists in the codebase: - `data` (`DataEl`/`Data`, `DataAttr` also exists) - `form` (`Form`/`FormAttr`, `FormEl` also exists) +- `label` (`Label`/`LabelAttr`, `LabelEl` also exists) - `style` (`StyleEl`/`Style`, `StyleAttr` also exists) - `title` (`TitleEl`/`Title`, `TitleAttr` also exists)
M html/elements.go → html/elements.go
@@ -168,6 +168,11 @@ func Label(children ...g.Node) g.Node { return g.El("label", children...) } +// Deprecated: Use [Label] instead. +func LabelEl(children ...g.Node) g.Node { + return g.El("label", children...) +} + func Legend(children ...g.Node) g.Node { return g.El("legend", children...) }
M html/elements_test.go → html/elements_test.go
@@ -79,6 +79,7 @@ {Name: "iframe", Func: IFrame}, {Name: "ins", Func: Ins}, {Name: "kbd", Func: Kbd}, {Name: "label", Func: Label}, + {Name: "label", Func: LabelEl}, {Name: "legend", Func: Legend}, {Name: "li", Func: Li}, {Name: "main", Func: Main},