about summary refs log tree commit diff stats
path: root/Makefile
diff options
context:
space:
mode:
authorMarkus Wüstenberg2020-10-29 15:40:14 +0100
committerGitHub2020-10-29 15:40:14 +0100
commit92ba5904c1645e6572f5ff1b9d0e0ec629e1afb9 (patch)
treea8152ee9fae45f724faf429c0bbd14c2ba62f15b /Makefile
parentf277d1942e9f2ec1ff4a3bc3c409e864103b506b (diff)
downloadgomponents-92ba5904c1645e6572f5ff1b9d0e0ec629e1afb9.tar.lz
gomponents-92ba5904c1645e6572f5ff1b9d0e0ec629e1afb9.tar.zst
gomponents-92ba5904c1645e6572f5ff1b9d0e0ec629e1afb9.zip
Remove fmt.Sprintf call in attribute Render (#38)
Just concatenating the strings is much faster.

Before:

```
make benchmark
go test -bench=.
goos: darwin
goarch: amd64
pkg: github.com/maragudk/gomponents
BenchmarkAttr/boolean_attributes-8         	 8194791	       139 ns/op
BenchmarkAttr/name-value_attributes-8      	 5143292	       229 ns/op
PASS
ok  	github.com/maragudk/gomponents	2.841s
```

After:

```
make benchmark
go test -bench=.
goos: darwin
goarch: amd64
pkg: github.com/maragudk/gomponents
BenchmarkAttr/boolean_attributes-8         	16755404	        67.0 ns/op
BenchmarkAttr/name-value_attributes-8      	10208625	       116 ns/op
PASS
ok  	github.com/maragudk/gomponents	2.702s
```
Diffstat (limited to 'Makefile')
-rw-r--r--Makefile5
1 files changed, 4 insertions, 1 deletions
diff --git a/Makefile b/Makefile
index dc8bb1f..c453239 100644
--- a/Makefile
+++ b/Makefile
@@ -1,4 +1,7 @@
-.PHONY: cover lint test
+.PHONY: benchmark cover lint test
+
+benchmark:
+	go test -bench=.
 
 cover:
 	go tool cover -html=cover.out