all repos — gomponents @ 794c3b26acbd3931b7973ff7e09a42b0ac414b1c

HTML components in pure Go

Render correct HTML5 (#44) Previously, elements of kind void and empty elements generally would be rendered auto-closing (with a final `/` character in the start tag), which is allowed sometimes but arguably wrong. See https://dev.w3.org/html5/spec-LC/syntax.html#end-tags This created problems with for example `textarea` and `script`, which cannot be auto-closing, or the browser renders it wrong. Also clarified in the docs that this library outputs HTML5. Fixes #42.

Markus Wüstenberg
commit

794c3b26acbd3931b7973ff7e09a42b0ac414b1c

parent

87d09c382434c9198c50356954fedf0ab8e5576f

1 file changed, 6 insertions(+), 6 deletions(-)

changed files
M el/elements_test.go → el/elements_test.go
@@ -17,7 +17,7 @@ }
 
 func TestDocument(t *testing.T) {
 	t.Run("returns doctype and children", func(t *testing.T) {
-		assert.Equal(t, `<!doctype html><html />`, el.Document(g.El("html")))
+		assert.Equal(t, `<!doctype html><html></html>`, el.Document(g.El("html")))
 	})
 
 	t.Run("errors on write error in Render", func(t *testing.T) {

@@ -28,13 +28,13 @@ }
 
 func TestForm(t *testing.T) {
 	t.Run("returns a form element with action and method attributes", func(t *testing.T) {
-		assert.Equal(t, `<form action="/" method="post" />`, el.Form("/", "post"))
+		assert.Equal(t, `<form action="/" method="post"></form>`, el.Form("/", "post"))
 	})
 }
 
 func TestInput(t *testing.T) {
 	t.Run("returns an input element with attributes type and name", func(t *testing.T) {
-		assert.Equal(t, `<input type="text" name="hat" />`, el.Input("text", "hat"))
+		assert.Equal(t, `<input type="text" name="hat">`, el.Input("text", "hat"))
 	})
 }
 

@@ -52,7 +52,7 @@ }
 
 func TestProgress(t *testing.T) {
 	t.Run("returns a progress element with attributes value and max", func(t *testing.T) {
-		assert.Equal(t, `<progress value="5.5" max="10" />`, el.Progress(5.5, 10))
+		assert.Equal(t, `<progress value="5.5" max="10"></progress>`, el.Progress(5.5, 10))
 	})
 }
 

@@ -65,7 +65,7 @@ }
 
 func TestTextarea(t *testing.T) {
 	t.Run("returns a textarea element with attribute name", func(t *testing.T) {
-		assert.Equal(t, `<textarea name="hat" />`, el.Textarea("hat"))
+		assert.Equal(t, `<textarea name="hat"></textarea>`, el.Textarea("hat"))
 	})
 }
 

@@ -77,6 +77,6 @@ }
 
 func TestImg(t *testing.T) {
 	t.Run("returns an img element with href and alt attributes", func(t *testing.T) {
-		assert.Equal(t, `<img src="hat.png" alt="hat" id="image" />`, el.Img("hat.png", "hat", g.Attr("id", "image")))
+		assert.Equal(t, `<img src="hat.png" alt="hat" id="image">`, el.Img("hat.png", "hat", g.Attr("id", "image")))
 	})
 }