Mark the assert test helpers as such (#90) Using `t.Helper()`. Also move the assert package to be internal.
Markus Wüstenberg markus@maragu.dk
Wed, 06 Oct 2021 20:49:43 +0200
9 files changed, 14 insertions(+), 11 deletions(-)
M assert/assert.go → internal/assert/assert.go
@@ -10,17 +10,20 @@ ) // Equal checks for equality between the given expected string and the rendered Node string. func Equal(t *testing.T, expected string, actual g.Node) { + t.Helper() + var b strings.Builder _ = actual.Render(&b) if expected != b.String() { - t.Errorf("expected `%v` but got `%v`", expected, actual) - t.FailNow() + t.Fatalf(`expected "%v" but got "%v"`, expected, actual) } } // Error checks for a non-nil error. func Error(t *testing.T, err error) { + t.Helper() + if err == nil { - t.FailNow() + t.Fatal("error is nil") } }
M components/attributes_test.go → components/attributes_test.go
@@ -5,8 +5,8 @@ "os" "testing" g "github.com/maragudk/gomponents" - "github.com/maragudk/gomponents/assert" c "github.com/maragudk/gomponents/components" + "github.com/maragudk/gomponents/internal/assert" ) func TestClasses(t *testing.T) {
M components/documents_test.go → components/documents_test.go
@@ -4,9 +4,9 @@ import ( "testing" g "github.com/maragudk/gomponents" - "github.com/maragudk/gomponents/assert" . "github.com/maragudk/gomponents/components" . "github.com/maragudk/gomponents/html" + "github.com/maragudk/gomponents/internal/assert" ) func TestHTML5(t *testing.T) {
M components/elements_test.go → components/elements_test.go
@@ -4,8 +4,8 @@ import ( "testing" g "github.com/maragudk/gomponents" - "github.com/maragudk/gomponents/assert" c "github.com/maragudk/gomponents/components" + "github.com/maragudk/gomponents/internal/assert" ) func TestInputHidden(t *testing.T) {
M gomponents_test.go → gomponents_test.go
@@ -9,7 +9,7 @@ "strings" "testing" g "github.com/maragudk/gomponents" - "github.com/maragudk/gomponents/assert" + "github.com/maragudk/gomponents/internal/assert" ) func TestNodeFunc(t *testing.T) {
M html/attributes_test.go → html/attributes_test.go
@@ -5,8 +5,8 @@ "fmt" "testing" g "github.com/maragudk/gomponents" - "github.com/maragudk/gomponents/assert" . "github.com/maragudk/gomponents/html" + "github.com/maragudk/gomponents/internal/assert" ) func TestBooleanAttributes(t *testing.T) {
M html/elements_test.go → html/elements_test.go
@@ -6,8 +6,8 @@ "fmt" "testing" g "github.com/maragudk/gomponents" - "github.com/maragudk/gomponents/assert" . "github.com/maragudk/gomponents/html" + "github.com/maragudk/gomponents/internal/assert" ) type erroringWriter struct{}
M svg/attributes_test.go → svg/attributes_test.go
@@ -5,7 +5,7 @@ "fmt" "testing" g "github.com/maragudk/gomponents" - "github.com/maragudk/gomponents/assert" + "github.com/maragudk/gomponents/internal/assert" . "github.com/maragudk/gomponents/svg" )
M svg/elements_test.go → svg/elements_test.go
@@ -5,7 +5,7 @@ "fmt" "testing" g "github.com/maragudk/gomponents" - "github.com/maragudk/gomponents/assert" + "github.com/maragudk/gomponents/internal/assert" . "github.com/maragudk/gomponents/svg" )