refactor: use Sprintf instead of string concatenation
1 file changed, 20 insertions(+), 23 deletions(-)
jump to
M templates/page.go → templates/page.go
@@ -1,6 +1,7 @@ package templates import ( + "fmt" "strings" "go.alanpearce.eu/elgit/config"@@ -36,23 +37,24 @@ func RenderHead(data PageData) []g.Node { var title string metaTitle := data.Meta.Title - if data.Parent != "" { - title = metaTitle + " — " + data.Name + " (" + data.Ref + "): " + data.Parent + "/" - } else if data.Path != "" { - title = metaTitle + " — " + data.Name + " (" + data.Ref + "): " + data.Path - } else if data.Files != nil { - title = metaTitle + " — " + data.Name + " (" + data.Ref + ")" - } else if data.Commit != nil { - title = metaTitle + " — " + data.Name + ": " + data.Commit.This - } else if data.Branches != nil { - title = metaTitle + " — " + data.Name + ": refs" - } else if data.Commits != nil { + switch { + case data.Parent != "": + title = fmt.Sprintf("%s — %s (%s): %s/", metaTitle, data.Name, data.Ref, data.Parent) + case data.Path != "": + title = fmt.Sprintf("%s — %s (%s): %s", metaTitle, data.Name, data.Ref, data.Path) + case data.Files != nil: + title = fmt.Sprintf("%s — %s (%s)", metaTitle, data.Name, data.Ref) + case data.Commit != nil: + title = fmt.Sprintf("%s — %s: %s", metaTitle, data.Name, data.Commit.This) + case data.Branches != nil: + title = fmt.Sprintf("%s — %s: refs", metaTitle, data.Name) + case data.Commits != nil: if data.Log { - title = metaTitle + " — " + data.Name + ": log" + title = fmt.Sprintf("%s — %s: log", metaTitle, data.Name) } else { - title = metaTitle + " — " + data.Name + title = fmt.Sprintf("%s — %s", metaTitle, data.Name) } - } else { + default: title = metaTitle }@@ -63,7 +65,7 @@ TitleEl(g.Text(title)), g.If(data.Servername != "" && data.Gomod, Meta( Name("go-import"), - Content(data.Servername+"/"+data.Name+" git https://"+data.Servername+"/"+data.Name), + Content(fmt.Sprintf("%s/%s git https://%[1]s/%[2]s", data.Servername, data.Name)), ), ), }@@ -85,14 +87,9 @@ func RepoHeader(data PageData) g.Node { return Header( H2( - A( - Href("/"), - g.Text("all repos"), - ), - g.Text(" — "), - g.Text(data.DisplayName), - g.Text(" "), - g.If(data.Ref != "", Span(Class("ref"), g.Textf("@ %s", data.Ref))), + A(Href("/"), g.Text("all repos")), + g.Textf(" — %s", data.DisplayName), + g.If(data.Ref != "", Span(Class("ref"), g.Textf(" @ %s", data.Ref))), ), H3(Class("desc"), g.Text(data.Description)), )