about summary refs log tree commit diff stats
path: root/internal/importer
diff options
context:
space:
mode:
authorAlan Pearce2024-05-23 13:22:50 +0200
committerAlan Pearce2024-05-23 13:22:50 +0200
commit052fce5bf2b1995fe45b88626e5342e61933d7cd (patch)
treee3c9b49250acee26c6aee1d43501c1cdddb83fc6 /internal/importer
parent0dbfe37fbddb95c184d845c79bbe014597d55fe8 (diff)
downloadsearchix-052fce5bf2b1995fe45b88626e5342e61933d7cd.tar.lz
searchix-052fce5bf2b1995fe45b88626e5342e61933d7cd.tar.zst
searchix-052fce5bf2b1995fe45b88626e5342e61933d7cd.zip
refactor: use a single value for per-source import timeouts
Diffstat (limited to 'internal/importer')
-rw-r--r--internal/importer/main.go4
-rw-r--r--internal/importer/options.go4
-rw-r--r--internal/importer/package.go4
3 files changed, 4 insertions, 8 deletions
diff --git a/internal/importer/main.go b/internal/importer/main.go
index 6be5b45..bd41af2 100644
--- a/internal/importer/main.go
+++ b/internal/importer/main.go
@@ -28,7 +28,7 @@ func createSourceImporter(
 			"fetcher",
 			source.Fetcher.String(),
 			"timeout",
-			source.FetchTimeout.Duration,
+			source.Timeout.Duration,
 		)
 		logger.Debug("starting fetcher")
 
@@ -42,7 +42,7 @@ func createSourceImporter(
 			sourceMeta.Updated = time.Time{}
 		}
 		previousUpdate := sourceMeta.Updated
-		ctx, cancel := context.WithTimeout(parent, source.FetchTimeout.Duration)
+		ctx, cancel := context.WithTimeout(parent, source.Timeout.Duration)
 		defer cancel()
 		files, err := fetcher.FetchIfNeeded(ctx, &sourceMeta)
 
diff --git a/internal/importer/options.go b/internal/importer/options.go
index 4089f62..c26836e 100644
--- a/internal/importer/options.go
+++ b/internal/importer/options.go
@@ -87,8 +87,7 @@ func NewOptionProcessor(infile io.ReadCloser, source *config.Source) (*OptionIng
 	return &i, nil
 }
 
-func (i *OptionIngester) Process(parent context.Context) (<-chan nix.Importable, <-chan error) {
-	ctx, cancel := context.WithTimeout(parent, i.source.ImportTimeout.Duration)
+func (i *OptionIngester) Process(ctx context.Context) (<-chan nix.Importable, <-chan error) {
 	results := make(chan nix.Importable)
 	errs := make(chan error)
 
@@ -96,7 +95,6 @@ func (i *OptionIngester) Process(parent context.Context) (<-chan nix.Importable,
 		defer i.infile.Close()
 		defer close(results)
 		defer close(errs)
-		defer cancel()
 
 	outer:
 		for mv := range i.dec.Stream() {
diff --git a/internal/importer/package.go b/internal/importer/package.go
index 3fee8d7..4e193db 100644
--- a/internal/importer/package.go
+++ b/internal/importer/package.go
@@ -104,8 +104,7 @@ func convertToLicense(in map[string]any) *nix.License {
 	return l
 }
 
-func (i *PackageIngester) Process(parent context.Context) (<-chan nix.Importable, <-chan error) {
-	ctx, cancel := context.WithTimeout(parent, i.source.ImportTimeout.Duration)
+func (i *PackageIngester) Process(ctx context.Context) (<-chan nix.Importable, <-chan error) {
 	results := make(chan nix.Importable)
 	errs := make(chan error)
 
@@ -113,7 +112,6 @@ func (i *PackageIngester) Process(parent context.Context) (<-chan nix.Importable
 		defer i.infile.Close()
 		defer close(results)
 		defer close(errs)
-		defer cancel()
 
 	outer:
 		for mv := range i.dec.Stream() {