From 3053e41b1528ef898cccd44e056e4d167619af6b Mon Sep 17 00:00:00 2001 From: Alan Pearce Date: Thu, 23 May 2024 11:45:38 +0200 Subject: fix: abort import of source on batch processing errors --- internal/importer/importer.go | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) (limited to 'internal/importer/importer.go') diff --git a/internal/importer/importer.go b/internal/importer/importer.go index 53a87c9..6803f00 100644 --- a/internal/importer/importer.go +++ b/internal/importer/importer.go @@ -21,7 +21,7 @@ func process( indexer *index.WriteIndex, processor Processor, logger *slog.Logger, -) bool { +) (bool, error) { wg := sync.WaitGroup{} wg.Add(1) @@ -30,7 +30,8 @@ func process( wg.Add(1) iErrs := indexer.Import(ctx, objects) - var hadErrors bool + var hadObjectErrors bool + var criticalError error go func() { for { select { @@ -42,7 +43,13 @@ func process( continue } - hadErrors = true + be, isBatchError := err.(*index.BatchError) + if isBatchError { + criticalError = be + + break + } + hadObjectErrors = true logger.Warn("error ingesting object", "error", err) case err, running := <-pErrs: if !running { @@ -52,7 +59,7 @@ func process( continue } - hadErrors = true + hadObjectErrors = true logger.Warn("error processing object", "error", err) } } @@ -60,5 +67,5 @@ func process( wg.Wait() - return hadErrors + return hadObjectErrors, criticalError } -- cgit 1.4.1