From 92ba5904c1645e6572f5ff1b9d0e0ec629e1afb9 Mon Sep 17 00:00:00 2001 From: Markus Wüstenberg Date: Thu, 29 Oct 2020 15:40:14 +0100 Subject: Remove fmt.Sprintf call in attribute Render (#38) Just concatenating the strings is much faster. Before: ``` make benchmark go test -bench=. goos: darwin goarch: amd64 pkg: github.com/maragudk/gomponents BenchmarkAttr/boolean_attributes-8 8194791 139 ns/op BenchmarkAttr/name-value_attributes-8 5143292 229 ns/op PASS ok github.com/maragudk/gomponents 2.841s ``` After: ``` make benchmark go test -bench=. goos: darwin goarch: amd64 pkg: github.com/maragudk/gomponents BenchmarkAttr/boolean_attributes-8 16755404 67.0 ns/op BenchmarkAttr/name-value_attributes-8 10208625 116 ns/op PASS ok github.com/maragudk/gomponents 2.702s ```--- gomponents.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'gomponents.go') diff --git a/gomponents.go b/gomponents.go index e6b89e1..f4b8467 100644 --- a/gomponents.go +++ b/gomponents.go @@ -129,9 +129,9 @@ type attr struct { func (a *attr) Render() string { if a.value == nil { - return fmt.Sprintf(" %v", a.name) + return " " + a.name } - return fmt.Sprintf(` %v="%v"`, a.name, *a.value) + return " " + a.name + `="` + *a.value + `"` } func (a *attr) Place() Placement { -- cgit 1.4.1