From ed360808d94ea0e637881158b393da52827573e9 Mon Sep 17 00:00:00 2001 From: Alan Pearce Date: Sun, 28 Sep 2014 14:22:51 +0100 Subject: select-h: use zippers for easier recursion That was far too easy. --- src/microformats/parser.clj | 10 ++++++---- test/microformats/parser_expectations.clj | 29 +++++++++++++++-------------- 2 files changed, 21 insertions(+), 18 deletions(-) diff --git a/src/microformats/parser.clj b/src/microformats/parser.clj index cf75a27..cebfcc7 100644 --- a/src/microformats/parser.clj +++ b/src/microformats/parser.clj @@ -258,9 +258,11 @@ (defn select-h "Select top-level h-* elements within a HTML element." - [element] - (html/select element [[(html/attr-contains :class "h-") - (html/but (parents (html/attr? :class)))]])) + [loc] + (when (not (z/end? loc)) + (if (some->> loc z/node first :attrs :class (re-matcher #"(?:^|\s) h-\w")) + (z/node loc) + (recur (z/next loc))))) (defn parse-rel "Parse rel attributes of an HTML link element" @@ -284,4 +286,4 @@ "Parse a HTML string with microformats" [html] (let [document (html/html-snippet html)] - {:items (mapv parse-h (select-h document)) :rels (parse-rels document)})) + {:items (mapv parse-h (some->> document z/xml-zip select-h)) :rels (parse-rels document)})) diff --git a/test/microformats/parser_expectations.clj b/test/microformats/parser_expectations.clj index 455a26f..5f8eeef 100644 --- a/test/microformats/parser_expectations.clj +++ b/test/microformats/parser_expectations.clj @@ -1,6 +1,7 @@ (ns microformats.parser-expectations (:require [expectations :refer :all] [microformats.parser :refer :all] + [clojure.zip :as z] [net.cgrand.enlive-html :refer [html-snippet]])) (defn- snippet @@ -25,25 +26,25 @@ (#'microformats.parser/node-to-text))) (expect '({:tag :div :attrs {:class "h-card"} - :content nil}) - (select-h (snippet - "
"))) + :content nil}) + (select-h (z/xml-zip (html-snippet + "
")))) (expect '({:tag :div :attrs {:class "h-card"} - :content ({:tag :a :attrs {:class "h-org"} - :content nil})}) - (select-h (snippet - "
"))) + :content ({:tag :a :attrs {:class "h-org"} + :content nil})}) + (select-h (z/xml-zip (html-snippet + "
")))) (expect '({:tag :div :attrs {:class "h-card"} - :content ("\n" - {:tag :p :attrs nil - :content ({:tag :a :attrs {:class "h-org"} - :content nil})} - "\n")}) - (select-h (snippet "
+ :content ("\n" + {:tag :p :attrs nil + :content ({:tag :a :attrs {:class "h-org"} + :content nil})} + "\n")}) + (select-h (z/xml-zip (html-snippet "

-
"))) +
")))) (expect {:name '("Name")} (parse-p (snippet "

Name

"))) -- cgit 1.4.1